[ 
https://issues.apache.org/jira/browse/CB-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114180#comment-15114180
 ] 

ASF GitHub Bot commented on CB-10423:
-------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-lib/pull/364

    CB-10423 Recursive error in plugin add ( windows )

    repro steps ;
    in a plugin repo that has a demo project, you may want to do something like 
this to allow other developers to run the demo:
    cd demo
    cordova plugin add ../ 
    
    windows does not allow symlink unless the shell is run with administrator 
privileges, which means the fix for [CB-8809] will still fail in most cases.
    
    The root of the problem is that we are attempting to copy src->dest when 
src contains dest, so we CAN proceed as long as we skip the destination folder 
from source.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-lib CB-10423

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #364
    
----
commit 0d195d41c0cb9fb960e06789c02fecd9e69a0c25
Author: Jesse MacFadyen <[email protected]>
Date:   2016-01-24T03:52:44Z

    allow recursive folder copy skipping whatever .. was

----


> Recursive error in plugin add ( windows )
> -----------------------------------------
>
>                 Key: CB-10423
>                 URL: https://issues.apache.org/jira/browse/CB-10423
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>         Environment: windows
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>
> windows does not allow symlink unless the shell is run with administrator 
> privileges, which means the fix for [CB-8809] will still fail in most cases.
> The root of the problem is that we are attempting to copy src->dest when src 
> contains dest, so we CAN proceed as long as we skip the destination folder 
> from source.
> repro steps ;
> in a plugin repo that has a demo project, you may want to do something like 
> this to allow other developers to run the demo:
> cd demo
> cordova plugin add ../ 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to