[ 
https://issues.apache.org/jira/browse/CB-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114976#comment-15114976
 ] 

Sergey Grebnov commented on CB-10326:
-------------------------------------

I like the idea, but I think we will miss target attribute support as 
resource-file will be always copied to root (pls correct me if I'm wrong). In 
some cases you will want to use resource-file to specify some asset which is 
available for the app in runtime (image/json/xml/etc) in some specific location.

https://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#link-resource-file-and-header-file-elements

Also, I believe using target attribute you will be able to get it working, for 
example
{code}
<resource-file src="x86/foo.dll" target="x86/foo.dll" arch="x86" />
<resource-file src="arm/foo.dll" target="arm/foo.dll" arch="arm" />
<resource-file src="x64/foo.dll" target="x64/foo.dll" arch="x64" />
{code}

> don't copy resource-file files at plugin install time
> -----------------------------------------------------
>
>                 Key: CB-10326
>                 URL: https://issues.apache.org/jira/browse/CB-10326
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Marco Biasini
>
> I just came across the newly added resource-file support for phonegap for 
> windows. I've tried to use it for adding native dlls dependencies to the 
> application. I couldn't completely get it to work with the current version.
> I'd like to propose a small change which would make the resource-file tag 
> more powerful and shouldn't impact existing users:
> Judging from the source code, the file is copied to the target when the 
> plugin is installed. I'd propose not to copy to the target but to point the 
> include parameter to the existing file. This allows use-cases where a 
> different .dll has to be copied based on the architecture of the project, 
> .e.g.
> <resource-file src="x86/foo.dll" arch="x86" />
> <resource-file src="arm/foo.dll" arch="arm" />
> <resource-file src="x64/foo.dll" arch="x64" />
> This should generate code like this for each resource-file entry:
>     <ItemGroup>
>         <Content Condition="'$(Platform)'=='x86'" Include="x86/foo.dll">
>             <Link>foo.dll</Link>
>             <CopyToOutputDirectory>Always</CopyToOutputDirectory>
>         </Content>
>     </ItemGroup>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to