[
https://issues.apache.org/jira/browse/CB-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117222#comment-15117222
]
ASF GitHub Bot commented on CB-10394:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/143
CB-10394 Do not cache manifest file while getting package name
This fixes [CB-10394](https://issues.apache.org/jira/browse/CB-10394)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-10394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit 0977140a2441824d9a77e6a8aeefd29d3a33fe19
Author: Vladimir Kotikov <[email protected]>
Date: 2016-01-26T10:35:17Z
CB-10394 Do not cache manifest file while getting package name
----
> config-file changes are not written to package.windows.appxmanifest
> -------------------------------------------------------------------
>
> Key: CB-10394
> URL: https://issues.apache.org/jira/browse/CB-10394
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.3.0
> Reporter: Marco Biasini
> Assignee: Vladimir Kotikov
> Labels: regression, triaged
>
> I've noticed that config-file changes defined in a plugin are not correctly
> written to package.windows.appxmanifest file. After a plugin import, the file
> does not contain these changes. The changes are correctly applied to the
> other appxmanifest files (phone, windows10, windows80).
> I've bested both with windows platform 4.3.0 as well as master and the
> problem exists in both branches.
> The problem is related to the appxmanifest caching mechanism. The
> package.windows.appxmanifest file is loaded early on to determine the package
> name (through jsprojManager.getPackageName()). The appxmanifest content is
> then cached in memory. Then, the config-file changes defined in the
> plugin.xml file are applied to the manifests and written to disk. They do not
> use the cached manifests from the earlier step,but rather load the files
> through a different code path. After that all previously cached appxmanifest
> instances are then written to disk, which effectively overwrites the content
> of package.windows.appxmanifest. Since this is the only manifest that gets
> loaded early on, this does not affect the other appxmanifest files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
