[
https://issues.apache.org/jira/browse/CB-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118933#comment-15118933
]
ASF GitHub Bot commented on CB-10441:
-------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/142
CB-10441 Add auto tests for InAppBrowser plugin
https://issues.apache.org/jira/browse/CB-10441
Added the following unit tests:
1. `cordova.InAppBrowser.open` method exists and return `InAppBrowser`
instance as a result
2. `loadstart` and `loadstop` events callbacks are called
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser
CB-10441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit ff705db31a6341326bbd2e56dff34908f77fccdc
Author: sgrebnov <[email protected]>
Date: 2016-01-27T09:35:44Z
CB-10441 Add auto tests for InAppBrowser plugin
----
> Add auto tests for InAppBrowser plugin
> --------------------------------------
>
> Key: CB-10441
> URL: https://issues.apache.org/jira/browse/CB-10441
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin InAppBrowser
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Priority: Minor
>
> We should test at least that there is InAppBrowser and InAppBrowser.open
> available to ensure plugin has been loaded successfully (no js errors/etc).
> {code}
> var ref = cordova.InAppBrowser.open
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
