[
https://issues.apache.org/jira/browse/CB-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138284#comment-15138284
]
ASF GitHub Bot commented on CB-10522:
-------------------------------------
Github user axemclion commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52264119
--- Diff: www/js/index.js ---
@@ -19,22 +19,20 @@
var app = {
// Application Constructor
initialize: function() {
- this.bindEvents();
- },
- // Bind Event Listeners
- //
- // Bind any events that are required on startup. Common events are:
- // 'load', 'deviceready', 'offline', and 'online'.
- bindEvents: function() {
document.addEventListener('deviceready', this.onDeviceReady,
false);
--- End diff --
Do we wanna do a this.onDeviceReady.bind(this) here ?
> Event binding in Hello World is misleading
> ------------------------------------------
>
> Key: CB-10522
> URL: https://issues.apache.org/jira/browse/CB-10522
> Project: Apache Cordova
> Issue Type: Bug
> Components: App Hello World
> Reporter: Richard B Knoll
> Assignee: Sarangan Rajamanickam
> Priority: Minor
> Labels: triaged
>
> It is our recommendation that you bind to all of the Cordova events
> ({{pause}}, {{resume}}, etc.) in your {{deviceready}} callback so as to
> ensure that cordova.js and all your plugins are done being loaded. This is
> mentioned in the events guide [in the
> documentation|http://cordova.apache.org/docs/en/latest/cordova/events/events.pause.html]
> However, we include a {{bindEvents}} method in the template which implies
> that all event binding should happen there. We should probably just remove
> {{bindEvents}} altogether and add the event listener for {{deviceready}} in
> the {{initialize}} method since the other events we mention seem to be out of
> date. We should also add a comment explaining where Cordova related events
> should be bound to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
