[
https://issues.apache.org/jira/browse/CB-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146026#comment-15146026
]
ASF GitHub Bot commented on CB-10488:
-------------------------------------
GitHub user TanaseButcaru opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/53
Fix MediaFile.getFormatData on Android (readded)
JIRA Issue [CB-10488](https://issues.apache.org/jira/browse/CB-10488)
JIRA Issue [CB-10489](https://issues.apache.org/jira/browse/CB-10489)
Also resolves this one #43 /
[CB-9611](https://issues.apache.org/jira/browse/CB-9611)
-------------
1. ``getFormatData`` was not working at all on Android (and iOS) because it
was using the ``localURL`` instead of ``fullPath``
2. audio recording was not even checking for metadata because the current
code is only searching for .3gpp audio files, but the default recording file
type for android is ``audio/amr``.
On my android 4.4, the Sound Recorder app has options from where the user
can change the output file type (it has wav, amr & 3gpp); some devices are
recording aac too.
All these file types for audio recording are now supported.
3. Related CB-9611 (PR#43) resolved without hardcoded ``file://`` string.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/TanaseButcaru/cordova-plugin-media-capture-unofficial
MediaFile-getFormat-20160213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 988cad058e14ec8518902d52baae447409aaa20e
Author: TanaseButcaru <[email protected]>
Date: 2016-01-31T22:42:07Z
Fix for MediaFile.getFormatData
commit e8b7fc5e6f5c4d4077646847999daaccba6f852d
Author: TanaseButcaru <[email protected]>
Date: 2016-02-03T21:49:06Z
Fix for MediaFile.getFormatData / audio recording support
commit 5fb509da851ccb2bc320776fa037975a365b80ed
Author: Tanase Butcaru <[email protected]>
Date: 2016-02-12T09:20:43Z
Merge pull request #1 from apache/master
chore: edit package.json license to match SPDX id
----
> MediaFile.getFormatData does not work with localURL; changed with fullPath
> --------------------------------------------------------------------------
>
> Key: CB-10488
> URL: https://issues.apache.org/jira/browse/CB-10488
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media Capture
> Environment: Android, iOS
> Reporter: Tanase Butcaru
> Labels: Android, iOS, media-capture, triaged
>
> _MediaFile.getFormatData_ result data was empty (filled with default "0"
> values) for all types of capture: image, video & audio.
> Problem encountered on Android & iOS.
> I solved this by changing the url passed to native code from _localURL_ to
> _fullPath_.
> Tested with two different Android phones (5.1 & 4.4) & one iPhone 5 (iOS 9).
> The fix works!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
