[
https://issues.apache.org/jira/browse/CB-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147357#comment-15147357
]
ASF GitHub Bot commented on CB-10574:
-------------------------------------
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/70#issuecomment-184211059
@sarangan12, LGTM, thank you for updating the PR!
A few notes:
- Could you please add a fallback for
[Number.EPSILON](https://github.com/sarangan12/cordova-plugin-geolocation/commit/a6da270a0bb8d6c83911d8d559c1bb37abe7bbcc#diff-670b1e761968f9ba2d95017f9a8a6187L169)
as it is undefined on Windows Phone 8.1?
-
[success](https://github.com/sarangan12/cordova-plugin-geolocation/commit/a6da270a0bb8d6c83911d8d559c1bb37abe7bbcc#diff-670b1e761968f9ba2d95017f9a8a6187L190)
is null in clearWatch so does it make sense to verify it has a value before
executing it? (`success && success()`)
> MobileSpec can't get results for WP8.1 Builds
> ---------------------------------------------
>
> Key: CB-10574
> URL: https://issues.apache.org/jira/browse/CB-10574
> Project: Apache Cordova
> Issue Type: Bug
> Environment: Windows
> Reporter: Omar Mefire
> Assignee: Sarangan Rajamanickam
> Priority: Critical
> Labels: found-by-ci, wp8.1
>
> Log 1:
> (https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1524/steps/running-tests/logs/stdio)
> ======
> CordovaApp.Phone ->
> C:\Users\buildbot\slaves\apache\cordova-windows-phone8_1\mobilespec\platforms\windows\AppPackages\CordovaApp.Phone_0.0.1.0_AnyCPU_bundle_debug.appxupload
> Your package has been successfully created.
> Deploying phone package to emulator:
> C:\Users\buildbot\slaves\apache\cordova-windows-phone8_1\mobilespec\platforms\windows\AppPackages\CordovaApp.Phone_0.0.1.0_debug_Test\CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle
> Attempting to remove previously installed application...
> Deploying app package...
> didn't get test results: timed out
> program finished with exit code 1
> elapsedTime=1143.444000
> ====
> Log 2:
> -----------
> ERROR running one or more of the platforms: Unexpected error from
> installation: C:\Program Files (x86)\Microsoft SDKs\Windows
> Phone\v8.1\Tools\AppDeploy\AppDeployCmd.exe: Command failed with exit code
> 2148734208 Error output:
> Error: Deployment failed because no Windows Phone was detected. Make sure a
> phone is connected and powered on. You may have previously installed the app
> with an earlier version of cordova-windows. Ensure the app is uninstalled
> from the phone and then try to run again.
> You may not have the required environment or OS to run this project
> [MEDIC LOG Mon, 08 Feb 2016 16:39:10 GMT] no device found, so switching to
> emulator
> ==========
> Log 3:
> https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1506/steps/running-tests/logs/stdio
> -----------
> Attempting to remove previously installed application...
> Deploying app package...
> query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> didn't get test results: timed out
> program finished with exit code 1
> elapsedTime=1142.741000
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
