[ 
https://issues.apache.org/jira/browse/CB-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148218#comment-15148218
 ] 

ASF subversion and git services commented on CB-10611:
------------------------------------------------------

Commit 990f2c63b83cccfb2773cc0e45197841efdf8fe6 in cordova-lib's branch 
refs/heads/master from [~bso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=990f2c6 ]

CB-10611 fix before_plugin_install hook not disabled with --nohooks

This closes #388


> --nohooks missed disabling before_plugin_install
> ------------------------------------------------
>
>                 Key: CB-10611
>                 URL: https://issues.apache.org/jira/browse/CB-10611
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Byoungro So
>            Assignee: Byoungro So
>
> --nohooks option does not disable before_plugin_install hook.
> This was missed from CB-8455.
> Here is the test scenario.
> {code}
> [nohooks-test] cordova plugin add cordova-plugin-device --nohooks .
> Fetching plugin "cordova-plugin-device@~1.1.1" via npm
> Installing "cordova-plugin-device" for ios
> Running command: 
> /Users/bso/cordova/test/nohooks-test/hooks/before_plugin_install/hook.js 
> /Users/bso/cordova/test/nohooks-test
> before plugin install hook executed
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to