[ 
https://issues.apache.org/jira/browse/CB-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148928#comment-15148928
 ] 

ASF GitHub Bot commented on CB-10618:
-------------------------------------

Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-android/pull/259#issuecomment-184778783
  
    LGTM. How can we add tests for this scenario?


> A logic for gradle frameworks processing should be in platform instead of LIB
> -----------------------------------------------------------------------------
>
>                 Key: CB-10618
>                 URL: https://issues.apache.org/jira/browse/CB-10618
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Android, CordovaLib
>    Affects Versions: 5.2.0, 6.0.1
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> After each plugin installtion/uninstallation LIB calls 
> {{build.prepBuildFiles()}} from android platform. However, since this is 
> platform-specific logic, this should be something that happens inside 
> addPlugin() function in cordova-android Api.js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to