[
https://issues.apache.org/jira/browse/CB-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150193#comment-15150193
]
ASF GitHub Bot commented on CB-10628:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/260#discussion_r53140038
--- Diff: bin/templates/cordova/lib/run.js ---
@@ -41,8 +41,9 @@ var path = require('path'),
var self = this;
- var install_target = runOptions.device ? '--device' :
- runOptions.emulator ? '--emulator' :
+ var install_target = !runOptions.target ?
--- End diff --
IMO this statement looks very complex - there is 3 ternary operators in one
expression. Could you please try to simplify this
> Fix emulate android --target
> ----------------------------
>
> Key: CB-10628
> URL: https://issues.apache.org/jira/browse/CB-10628
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Labels: regression
>
> {noformat}
> λ cordova emulate android --target=a19
> ANDROID_HOME=e:\Android\Sdk
> JAVA_HOME=C:\Program Files (x86)\java\jdk1.7.0_55
> No emulator specified, defaulting to Nexus_5_API_23_x86
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
