[
https://issues.apache.org/jira/browse/CB-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152207#comment-15152207
]
ASF GitHub Bot commented on CB-10641:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/393
CB-10641 Run prepare _after_ plugins were installed
This is a fix for
[CB-10641](https://issues.apache.org/jira/browse/CB-10641) and
[CB-10586](https://issues.apache.org/jira/browse/CB-10586)
This PR changes order of operations in `cordova.raw.platform('add', ...)`
method so `cordova.raw.prepare` is called after all plugins installed into
platform. Also apart from resolving the issue above, the new flow
(`platform_add -> install_plugins -> prepare`) looks semantically more correct.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10641
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #393
----
commit 3b9face5187857d354d85f3e3f4316cbace100db
Author: Vladimir Kotikov <[email protected]>
Date: 2016-02-17T15:48:31Z
CB-10641 Run prepare _after_ plugins were installed
commit b04db5feaf5516836c8a157cc3331b75d6dca0eb
Author: Vladimir Kotikov <[email protected]>
Date: 2016-02-18T10:08:47Z
CB-10641 Adds tests for order of operations in platform add
----
> `cordova platform add` doesn't copy plugin files to www
> -------------------------------------------------------
>
> Key: CB-10641
> URL: https://issues.apache.org/jira/browse/CB-10641
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: regression
> Fix For: 6.1.0
>
>
> Using cordova 6.0.0, if you {{cordova create foo && cordova plugin add
> cordova-plugin-camera && cordova platform add ios}}, the plugins show up as
> installed in {{fetch.json}} and the plugins folder, but {{platforms/ios/www}}
> does not have any of the plugin javascript installed. If you then do a
> {{cordova prepare ios}}, the plugin javascript is added as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
