[
https://issues.apache.org/jira/browse/CB-10644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153066#comment-15153066
]
ASF GitHub Bot commented on CB-10644:
-------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/394#discussion_r53380925
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -48,11 +48,17 @@ function getPlatformApi(platform, platformRootDir) {
var PlatformApi;
try {
// First we need to find whether platform exposes its' API via js
module
- // If it has, then we have to require it and extend BasePlatformApi
- // with platform's API.
+ // If it does, then we require and instantiate it.
var platformApiModule = path.join(platformRootDir, 'cordova',
'Api.js');
PlatformApi = require(platformApiModule);
} catch (err) {
+ // Check if platform already compatible w/ PlatformApi and show
deprecation warning
+ if (err && err.code === 'MODULE_NOT_FOUND' &&
platforms[platform].apiCompatibleSince) {
+ events.emit('warn', 'The support for cordova-' + platform + '
via PlatformApi polyfill ' +
--- End diff --
instead of leaking internal implementation detail we should consider
re-phrasing this as:
"Using this version of cordova CLI with older version of cordova-<platform>
is being deprecated. Consider upgrading to..."
> Deprecate support for old versions of PlatformApi-enabled platforms
> -------------------------------------------------------------------
>
> Key: CB-10644
> URL: https://issues.apache.org/jira/browse/CB-10644
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaLib
> Affects Versions: 6.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: PlatformAPI, PlatformApi
>
> The list of platforms that currently have a PlatofrmApi implementation and
> hence support for old versions of these platforms via PlatformApi polyfill
> might be deprecated/removed:
> * cordova-android < 5
> * cordova-ios < 4
> * cordova-windows < 4.3.0
> * cordova-osx < 4
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
