[ 
https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Byoungro So updated CB-10314:
-----------------------------
    Description: 
As of Cordova 5.4.0, an old plugin id is automatically converted to a new id 
using the corodva-registry-mapper.
This causes a new id to be fetched even if an old id is already fetched in the 
plugins directory (at cordova-lib/src/plugman/install.js)
However, plugman/fetch.js/copyPlugin() checks if the alias id is already in the 
plugins directory, and skips installing the fetched newId plugin.
This causes unnecessary overhead.
It is better to check if the oldId is already fetched, and skips fetching the 
newId from the beginning.
{code}
[t6.0.1] cordova plugins
cordova-plugin-whitelist 1.2.1 "Whitelist"
org.apache.cordova.device 0.3.0 "Device"
[t6.0.1] cordova plugin add org.apache.cordova.device
Notice: org.apache.cordova.device has been automatically converted to 
cordova-plugin-device to be fetched from npm. This is due to our old plugins 
registry shutting down.
Fetching plugin "cordova-plugin-device" via npm
cordova-plugin-device" will not install due to 
"/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being 
installed.
Notice: org.apache.cordova.device has been automatically converted to 
cordova-plugin-device and fetched from npm. This is due to our old plugins 
registry shutting down.
Fetching plugin "cordova-plugin-device" via npm
cordova-plugin-device" will not install due to 
"/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being 
installed.
Plugin "org.apache.cordova.device" already installed on ios.
{code}

  was:
As of Cordova 5.4.0, an old plugin id is automatically converted to a new id 
using the corodva-registry-mapper.
This causes a new id to be fetched even if an old id is already fetched in the 
plugins directory (at cordova-lib/src/plugman/install.js)
However, plugman/fetch.js/copyPlugin() checks if the alias id is already in the 
plugins directory, and skips installing the fetched newId plugin.
This causes unnecessary overhead.
It is better to check if the oldId is already fetched, and skips fetching the 
newId from the beginning.



> avoid fetching newId when oldId is already fetched
> --------------------------------------------------
>
>                 Key: CB-10314
>                 URL: https://issues.apache.org/jira/browse/CB-10314
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Byoungro So
>            Assignee: Byoungro So
>            Priority: Minor
>              Labels: triaged
>
> As of Cordova 5.4.0, an old plugin id is automatically converted to a new id 
> using the corodva-registry-mapper.
> This causes a new id to be fetched even if an old id is already fetched in 
> the plugins directory (at cordova-lib/src/plugman/install.js)
> However, plugman/fetch.js/copyPlugin() checks if the alias id is already in 
> the plugins directory, and skips installing the fetched newId plugin.
> This causes unnecessary overhead.
> It is better to check if the oldId is already fetched, and skips fetching the 
> newId from the beginning.
> {code}
> [t6.0.1] cordova plugins
> cordova-plugin-whitelist 1.2.1 "Whitelist"
> org.apache.cordova.device 0.3.0 "Device"
> [t6.0.1] cordova plugin add org.apache.cordova.device
> Notice: org.apache.cordova.device has been automatically converted to 
> cordova-plugin-device to be fetched from npm. This is due to our old plugins 
> registry shutting down.
> Fetching plugin "cordova-plugin-device" via npm
> cordova-plugin-device" will not install due to 
> "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being 
> installed.
> Notice: org.apache.cordova.device has been automatically converted to 
> cordova-plugin-device and fetched from npm. This is due to our old plugins 
> registry shutting down.
> Fetching plugin "cordova-plugin-device" via npm
> cordova-plugin-device" will not install due to 
> "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being 
> installed.
> Plugin "org.apache.cordova.device" already installed on ios.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to