[
https://issues.apache.org/jira/browse/CB-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156081#comment-15156081
]
ASF GitHub Bot commented on CB-10658:
-------------------------------------
GitHub user sajacy opened a pull request:
https://github.com/apache/cordova-lib/pull/397
CB-10658: Downgrade error to warning
Replace error with warning message if search paths differ.
(which does happen with `cca` tool from the MobileChromeApps project)
Generally, if the `localPlugins` cache variable has been previously set,
(e.g. via programmatically calling plugin add), then subsequent calls with
differing paths will cause the process to exit, which seems a bit extreme.
As the comments suggest, this is simply not implemented, not a failure
state, and can be safely passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sajacy/cordova-lib patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit c1d985855049fa844d2823d9e0d0c81447fc92d8
Author: Jeffrey Yang <[email protected]>
Date: 2016-02-21T15:44:13Z
Downgrade error to warning
Replace error with warning message if search paths differ.
(which does happen with `cca` tool from the MobileChromeApps project)
Generally, if the `localPlugins` cache variable has been previously set,
(via programmatically calling plugin add), then subsequent calls with
differing paths will cause the process to exit, which seems a bit extreme.
As the comments suggest, this is simply not implemented, not a failure
state, and can be safely passed.
----
> Plugin restore fails under MobileChromeApps `cca` tool
> ------------------------------------------------------
>
> Key: CB-10658
> URL: https://issues.apache.org/jira/browse/CB-10658
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.0.0
> Reporter: Jeffrey Yang
> Priority: Trivial
> Fix For: 6.0.0
>
>
> When preparing a MobileChromeApps-wrapped project, plugins from the
> config.xml are found, but restoration fails because the `cca` tool injects
> additional search paths, which causes plugman/fetch.js to throw an error.
> https://github.com/apache/cordova-lib/blob/6.0.x/cordova-lib/src/plugman/fetch.js#L199
> .
> I propose removing the error and simply emit a warning and continue with the
> cached localPlugin object.
> In this particular case, the `cca` tool adds the same search path twice (once
> via `opts`, other via `config_json`). While it would be good to also file a
> bug in the MobileChromeApps project, it's been stated that the project is no
> longer being actively maintained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
