[
https://issues.apache.org/jira/browse/CB-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163255#comment-15163255
]
ASF GitHub Bot commented on CB-10662:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/398
CB-10662 Apply project config to platform before installing any plugins
JIRA: [CB-10662](https://issues.apache.org/jira/browse/CB-10662)
This change is needed because some platforms (`browser` in particular)
doesn't contain own `config.xml` and rely on cordova, which generates one from
defaults during `prepare`. However, prepare now called after plugin
installation (after b04db5feaf5516836c8a157cc3331b75d6dca0eb) and hence fails
due to abscence of config.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10662
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #398
----
commit 890fb8ea27baef5d384c906756e4c01eaaf5ed7e
Author: Vladimir Kotikov <[email protected]>
Date: 2016-02-24T16:03:41Z
CB-10662 Apply project config to platform before installing any plugins
----
> Adding browser platform fails if plugins added since fix for CB-10641
> ---------------------------------------------------------------------
>
> Key: CB-10662
> URL: https://issues.apache.org/jira/browse/CB-10662
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Tim Barham
> Assignee: Vladimir Kotikov
> Priority: Blocker
> Labels: browser, regression, triaged
>
> Since the fix for [CB-10641|https://issues.apache.org/jira/browse/CB-10641],
> adding the browser platform throws an exception if a plugin has been added to
> the project:
> {noformat}
> $ cordova create AddBrowserError
> Creating a new cordova project.
> $ cd AddBrowserError
> $ cordova plugin add cordova-plugin-device
> Fetching plugin "cordova-plugin-device@~1.1.1" via npm
> $ cordova platform add browser
> Adding browser project...
> Running command: cmd "/s /c "cordova-browser\4.0.0\package\bin\create.bat
> AddBrowserError\platforms\browser io.cordova.hellocordova HelloCordova""
> Creating Browser project. Path: platforms\browser
> Installing "cordova-plugin-device" for browser
> Failed to install 'cordova-plugin-device':Error: ENOENT: no such file or
> directory, open 'AddBrowserError\platforms\browser\config.xml'
> at Error (native)
> at Object.fs.openSync (fs.js:549:18)
> at Object.fs.readFileSync (fs.js:397:15)
> at Object.module.exports.parseElementtreeSync
> (cordova-common\src\util\xml-helpers.js:118:27)
> at Object.module.exports.package_name
> (cordova-lib\src\plugman\platforms\browser.js:51:38)
> at cordova-lib\src\platforms\PlatformApiPoly.js:264:67
> at _fulfilled (cordova-common\node_modules\q\q.js:834:54)
> at self.promiseDispatch.done (cordova-common\node_modules\q\q.js:863:30)
> at Promise.promise.promiseDispatch
> (cordova-common\node_modules\q\q.js:796:13)
> at cordova-common\node_modules\q\q.js:857:14
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
