[
https://issues.apache.org/jira/browse/CB-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15164393#comment-15164393
]
ASF GitHub Bot commented on CB-10690:
-------------------------------------
GitHub user JonHerr opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/56
CB-10690 windows: fix crash when user cancels/closes photo app
wrapped the file.moveAsync() function with a check for file and return
CaptureError.CAPTURE_NO_MEDIA_FILES when file is undefiened
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonHerr/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 395be1120171b686d5dbed9e32b32c9e70087a10
Author: Jonathan Herr <[email protected]>
Date: 2016-02-24T19:24:17Z
CB-10690 windows: fix crash when user cancels/closes photo app
----
> windows 8/10 crash with user cancellation
> -----------------------------------------
>
> Key: CB-10690
> URL: https://issues.apache.org/jira/browse/CB-10690
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media Capture
> Affects Versions: 5.4.1
> Environment: windows
> Reporter: Jonathan Herr
> Labels: easyfix, windows
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When the user cancels taking an image or video the response back is
> undefined. then the proxy attempts to invoke a moveAsync() on the undefined
> object. this causes an error to be thrown rather than return a
> captureError.CAPTURE_NO_MEDIA_FILES.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
