[ 
https://issues.apache.org/jira/browse/CB-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173285#comment-15173285
 ] 

ASF GitHub Bot commented on CB-10729:
-------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/265#discussion_r54526677
  
    --- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
    @@ -31,7 +31,7 @@ var handlers = {
                 if (!obj.src) throw new CordovaError('<source-file> element is 
missing "src" attribute for plugin: ' + plugin.id);
                 if (!obj.targetDir) throw new CordovaError('<source-file> 
element is missing "target-dir" attribute for plugin: ' + plugin.id);
                 var dest = path.join(obj.targetDir, path.basename(obj.src));
    -            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, 
options && options.link);
    +            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, 
!!(options && options.link));
    --- End diff --
    
    Did the test find a bug here?


> Plugin handlers tests for Android should be kept in platform's repo
> -------------------------------------------------------------------
>
>                 Key: CB-10729
>                 URL: https://issues.apache.org/jira/browse/CB-10729
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Android
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>              Labels: android, tests
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to