[
https://issues.apache.org/jira/browse/CB-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178574#comment-15178574
]
ASF GitHub Bot commented on CB-10632:
-------------------------------------
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/106
CB-10632: Fixing jasmine test contact removal
This is related to the flaky tests that have been failing in the
android-win CI. As the jasmine tests execute, they create contacts and
occasionally fail to remove them. When that happens, the created contacts will
never be removed and all of the tests that depend on those contacts not
existing will fail until someone manually deletes the contacts on the emulator.
This PR does not fix the test flakiness issue, but does fix the issue of the
tests being permanently broken by a single failure. It also makes it so that
the removal failures will actually be reported by jasmine where they were not
previously so that we can hopefully pinpoint the real issue and fix the flaky
test in a later PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-10632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 85a16a8bdb82098891dfe8e13996aebf44f72d77
Author: riknoll <[email protected]>
Date: 2016-03-03T20:13:29Z
CB-10632: Fixing jasmine test contact removal
----
> Contact Plugin tests fail on cordova-andorid-win
> ------------------------------------------------
>
> Key: CB-10632
> URL: https://issues.apache.org/jira/browse/CB-10632
> Project: Apache Cordova
> Issue Type: Test
> Reporter: Raghav Katyal
> Assignee: Richard B Knoll
> Labels: cordova-android-win, found-by-ci
>
> Recent build links:
> https://ci.apache.org/builders/cordova-android-win/builds/1626
> https://ci.apache.org/builders/cordova-android-win/builds/1625
> Build log:
> Failing tests:
> cordova-plugin-contacts-tests.tests >> Contacts (navigator.contacts)
> Round trip Contact tests (creating + save + delete + find) contacts.spec.25
> Creating, saving, finding a contact should work
> Expected 2 to be 1.
> Error: Expected 2 to be 1.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWin
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:519:47)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:57:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
> at processMessages
> (file:///android_asset/www/cordova.js:1104:9)
> cordova-plugin-contacts-tests.tests >> Contacts (navigator.contacts)
> Round trip Contact tests (creating + save + delete + find) contacts.spec.26
> Creating, saving, finding a contact should work, removing it should work
> Expected 2 to be 1.
> Error: Expected 2 to be 1.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWin
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:519:47)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:57:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
> cordova-plugin-contacts-tests.tests >> Contacts (navigator.contacts)
> Round trip Contact tests (creating + save + delete + find) contacts.spec.27
> Should not be able to delete the same contact twice
> Expected 2 to be 1.
> Error: Expected 2 to be 1.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWin
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:519:47)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:57:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
> Expected 1 to be 0.
> Error: Expected 1 to be 0.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWin
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:577:49)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:57:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
