[ 
https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183802#comment-15183802
 ] 

ASF GitHub Bot commented on CB-8976:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/540#discussion_r55280038
  
    --- Diff: www/docs/en/dev/config_ref/index.md ---
    @@ -57,7 +57,7 @@ platform. See [Customize icons topic](images.html) for 
more information.
        ---------------- | ------------
        id(string) | *Required* <br/> Specifies the app's reverse-domain 
identifier, and the `version` its full version number expressed in 
major/minor/patch notation.
        version(string) | *Required* <br/> Full version number expressed in 
major/minor/patch notation.
    -   versionCode(string) | ==Android== <br/> Alternative version for 
Android. For further details, see [Android 
versioning](http://developer.android.com/tools/publishing/versioning.html)
    +   android-versionCode(string) | ==Android== <br/> Alternative version for 
Android. Sets the [version 
code](http://developer.android.com/tools/publishing/versioning.html) for the 
application. See [the Android 
guide](../guide/platforms/android/index.html#setting-the-version-code) for 
information on how this code may be modified.
    --- End diff --
    
    'how this code' => 'how this attribute'


> platforms/android/build.gradle modifies android versionCode
> -----------------------------------------------------------
>
>                 Key: CB-8976
>                 URL: https://issues.apache.org/jira/browse/CB-8976
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Android
>            Reporter: zack dykes
>            Assignee: Joe Bowser
>            Priority: Minor
>
> cordova 5.0.0
> platforms/android/build.gradle modifies android versionCode at ln 178
> as I understand it max size for versionCode is (2^31)-1 
> http://stackoverflow.com/a/24246191/126600
> in my config.xml: 
> {code}
> android-versionCode="1385039613"
> {code}
> when I run {{cordova build android}}, I get:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 
> '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle'
>  line: 178
> * What went wrong:
> A problem occurred evaluating root project 'android'.
> > For input string: "13850396130"
> {code}
> and build.gradle, ln 178
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + 
> privateHelpers.extractIntFromManifest("versionCode") + "0")
> {code}
> looks like this is appending "0" to my versionCode, producing 13850396130 
> which is larger than max size for android versionCode
> if I mod ln 178 as follows, build succeeds
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + 
> privateHelpers.extractIntFromManifest("versionCode"))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to