[ 
https://issues.apache.org/jira/browse/CB-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186020#comment-15186020
 ] 

ASF GitHub Bot commented on CB-7862:
------------------------------------

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443526
  
    --- Diff: tests/tests.js ---
    @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
                         expect(true).toFailWithMessage('Platform does not 
supported this feature');
                         done();
                     }
    -                runReaderTest('readAsArrayBuffer', true, done, function 
(evt, fileData, fileDataAsBinaryString) {
    +                runReaderTest('readAsArrayBuffer', true, done, null, 
function (evt, fileData, fileDataAsBinaryString) {
                         expect(arrayBufferEqualsString(evt.target.result, 
fileDataAsBinaryString.slice(0, -1))).toBe(true);
                         done();
                     }, 0, -1);
                 });
    -        });
    +            it("file.spec.94.5 should read large file in multiple chunks, 
readAsArrayBuffer", function (done) {
    +                // Skip test if ArrayBuffers are not supported (e.g.: 
Android 2.3).
    +                if (typeof window.ArrayBuffer == 'undefined') {
    +                    expect(true).toFailWithMessage('Platform does not 
supported this feature');
    --- End diff --
    
    Also, shouldn't this just be pending?


> FileReader reads large files in a single chunk causing OOM exceptions
> ---------------------------------------------------------------------
>
>                 Key: CB-7862
>                 URL: https://issues.apache.org/jira/browse/CB-7862
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>    Affects Versions: 4.0.0
>         Environment: Android
>            Reporter: shenzhuxi
>            Assignee: Jason Ginchereau
>            Priority: Critical
>
> In Android, I tried to copy a 14MB file from html file input with 
> org.apache.cordova.file 1.3.1. The App crashed and a 0 byte file was copied. 
> I use http://ngcordova.com/ and here is my code 
> https://github.com/shenzhuxi/readiator/blob/master/src/js/cordova-index.js. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to