[
https://issues.apache.org/jira/browse/CB-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189650#comment-15189650
]
ASF GitHub Bot commented on CB-10600:
-------------------------------------
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-android/pull/273
[CB-10600] 'cordova run --release' uses wrong apk
When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.
The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.
Fixes https://issues.apache.org/jira/browse/CB-10600
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpolivy/cordova-android CB10600
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit c788355ab1cb6234441166bbc92ca7b5c6c4c52b
Author: Dan Polivy <[email protected]>
Date: 2016-03-10T18:05:52Z
[CB-10600] 'cordova run --release' uses wrong apk
When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.
The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.
Fixes https://issues.apache.org/jira/browse/CB-10600
----
> 'cordova run android --release' does not use signed and zip-aligned version
> of APK
> ----------------------------------------------------------------------------------
>
> Key: CB-10600
> URL: https://issues.apache.org/jira/browse/CB-10600
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Environment: Tested on Windows 8.1 with Cordova CLI 6.0.0 (and Ionic
> CLI 1.7.14)
> Reporter: Eric Gopak
> Assignee: Joe Bowser
> Priority: Minor
> Labels: triaged
>
> Running command `cordova run android --release` builds the app successfully,
> both unsigned and signed/zip-aligned versions. However, it then tries to use
> the unsigned version of the APK. Here are the last lines of the output:
> .....
> BUILD SUCCESSFUL
> Total time: 31.35 secs
> Built the following apk(s):
>
> C:/XXXXX/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> C:/XXXXX/platforms/android/build/outputs/apk/android-armv7-release.apk
> Using apk:
> C:/XXXXX/platforms/android/build/outputs/apk/android-armv7-release-unsigned.apk
> ERROR running one or more of the platforms: Failed to install apk to device:
> pkg: /data/local/tmp/android-armv7-release-unsigned.apk
> Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES]
> You may not have the required environment or OS to run this project
> It has worked before I updated Cordova with 'npm install -g cordova'.
> I specify signing properties in a file 'release-signing.properties', which I
> copy to platforms/android/ folder. During the run/build I get prompted for
> the password, just as it has always been.
> I believe it is just a problem of choosing the wrong APK from the list of
> built APKs (Cordova probably chooses the one that comes earlier
> lexicographically)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]