[
https://issues.apache.org/jira/browse/CB-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195732#comment-15195732
]
ASF GitHub Bot commented on CB-10831:
-------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/160#discussion_r56205299
--- Diff: template/cordova/lib/prepare.js ---
@@ -172,6 +172,15 @@ function applyCoreProperties(config, manifest) {
manifest.getVisualElements().setDisplayName(name);
}
+ var description = config.description();
+ manifest.getProperties().setDescription(description);
+ if (description) {
--- End diff --
This breaks if say you add a description to config.xml and then remove it -
the old description will remain in appxmanifest - we might have to revert back
the old description in this case.
> Description not copied from config.xml to appxmanifest on Windows
> -----------------------------------------------------------------
>
> Key: CB-10831
> URL: https://issues.apache.org/jira/browse/CB-10831
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 6.0.0
> Environment: Windows
> Reporter: Paul Hickman
> Assignee: Vladimir Kotikov
> Priority: Minor
> Labels: mustfix, prepare, triaged, windows
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If you populate the <description> element in config.xml, prepare does not
> copy this into the <m2:VisualElements> tag's description attribute in the
> appxmanifest files for the windows projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
