[
https://issues.apache.org/jira/browse/CB-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201734#comment-15201734
]
ASF GitHub Bot commented on CB-10833:
-------------------------------------
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/282#discussion_r56683077
--- Diff: bin/templates/cordova/Api.js ---
@@ -263,48 +220,15 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaError instance.
*/
Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-
- if (!plugin || plugin.constructor.name !== 'PluginInfo')
- return Q.reject(new CordovaError('The parameter is incorrect. The
first parameter to addPlugin should be a PluginInfo instance'));
-
- var self = this;
- var actions = new ActionStack();
var project = AndroidProject.getProjectFile(this.root);
+ return PluginManager.get(this.platform, this.locations, project)
+ .addPlugin(plugin, uninstallOptions)
--- End diff --
did u mean ```.removePlugin``` ?
> Deduplicate common logic for plugin installation/uninstallation in platforms
> ----------------------------------------------------------------------------
>
> Key: CB-10833
> URL: https://issues.apache.org/jira/browse/CB-10833
> Project: Apache Cordova
> Issue Type: Task
> Components: Android, CordovaCommon, iOS, Windows
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
