[ 
https://issues.apache.org/jira/browse/CB-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211177#comment-15211177
 ] 

ASF GitHub Bot commented on CB-10771:
-------------------------------------

GitHub user rakatyal opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/133

    CB-10771: Fixing failure when empty string passed as a value for opti…

    …on parameter in upload function
    
    CreateUploadAsync fails when passed an empty string as a value for SetText 
function. It also fails when we skip specifying a value for it. So when a user 
passes an empty string, pass " " instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
raghav-CB-10771

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit 45c98415c4e56ac7cc014c23b7453eddacc332ef
Author: Raghav Katyal <[email protected]>
Date:   2016-03-25T00:17:15Z

    CB-10771: Fixing failure when empty string passed as a value for option 
parameter in upload function

----


> plugin-file-transfer upload on windows fails when params has a key with a 
> null value
> ------------------------------------------------------------------------------------
>
>                 Key: CB-10771
>                 URL: https://issues.apache.org/jira/browse/CB-10771
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 1.5.0
>         Environment: Windows, cordova 6.0.0
>            Reporter: Paul Hickman
>            Assignee: Raghav Katyal
>              Labels: windows
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In the windows version of plugin-file-transfer, if you set the options such 
> that a key inside the params object has a null value: e.g.
> var options = { params: { keyName: null } }
> Then it will fail to upload with an INVALID_URL error because an exception 
> occurs trying to convert the key keyName into a transfer chunk.
> This does not cause an error in the ios or android versions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to