[
https://issues.apache.org/jira/browse/CB-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214882#comment-15214882
]
ASF GitHub Bot commented on CB-10940:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57632693
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if (!(eventEmitter instanceof EventEmitter))
throw new Error('Cordova events could be redirected to another
EventEmitter instance only');
- EVENTS_RECEIVER = eventEmitter;
+ // Skipping forwarding to self to avoid infinite recursion.
+ // This is the case when the modules are npm-linked.
+ if(this !== eventEmitter) {
--- End diff --
nit: please add space after `if`. Also could you please reference JIRA here
so it'd be more clear why we're checking this
> Can't add Android platform from path
> ------------------------------------
>
> Key: CB-10940
> URL: https://issues.apache.org/jira/browse/CB-10940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: Master
> Environment: Tried on Windows and Mac
> 6.1.1-dev ([email protected])
> Reporter: Karen Tran
> Assignee: Sergey Shakhnazarov
> Labels: android, platform
> Fix For: Master
>
>
> Ran into this issue when trying to create mobile-spec. I cannot add the
> android platform from a path. This only happens on master. If I switch
> cordova-android repo to 5.1.x branch, this issue doesn't happen.
> Error from Mac:
> {noformat}
> myComputer$ cordova platform add ../cordova-android -dd
> Executing "before_platform_add" hook for all plugins.
> Adding android project...
> PlatformApi successfully found for platform android
> /Users/myComputer/cordova_apache_master/cordova-cli/node_modules/cordova-common/src/CordovaLogger.js:212
> if(message.toUpperCase().indexOf('ERROR:') !== 0) {
> ^
> TypeError: Cannot call method 'toUpperCase' of undefined
> at formatError
> (/Users/myComputer/cordova_apache_master/cordova-cli/node_modules/cordova-common/src/CordovaLogger.js:212:16)
> at CordovaLogger.log
> (/Users/myComputer/cordova_apache_master/cordova-cli/node_modules/cordova-common/src/CordovaLogger.js:93:19)
> at process.<anonymous>
> (/Users/myComputer/cordova_apache_master/cordova-cli/src/cli.js:136:16)
> at process.EventEmitter.emit (events.js:95:17)
> at process._fatalException (node.js:272:26){noformat}
> Error from Windows:
> {noformat}
> Error: RangeError: Maximum call stack size exceeded
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30)
> at EventEmitter.module.exports.emit
> (C:\Users\myComputer\cordova_master\cordo
> va-lib\cordova-common\src\events.js:61:30) {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
