[
https://issues.apache.org/jira/browse/CB-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216825#comment-15216825
]
ASF GitHub Bot commented on CB-10927:
-------------------------------------
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57799518
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var dest = src;
var type = obj.type;
+ var targetDir = obj.targetDir || '';
if(type === 'projectReference') {
- project.addProjectReference(path.join(plugin.dir,src),
getTargetConditions(obj));
- }
- else {
- var targetDir = obj.targetDir || '';
+ dest = path.join('plugins', plugin.id, targetDir, src);
+ project.addProjectReference(dest,
getTargetConditions(obj));
--- End diff --
Since this is common to both conditions, consider taking it out and putting
it after the if else statement.
> Framework references in plugin.xml file prevent Windows Universal projects
> from being used on other machines
> ------------------------------------------------------------------------------------------------------------
>
> Key: CB-10927
> URL: https://issues.apache.org/jira/browse/CB-10927
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: James Dubee
> Labels: triaged
>
> For Windows Universal, a framework reference in plugin.xml files results in a
> hardcoded path being written to CordovaApp.sln, and CordovaApp.Phone.jsproj.
> This hardcoded path is specific to the user's machine in which the plugin was
> installed on. This prevents moving a project from one machine to another
> without manually editing CordovaApp.sln, and CordovaApp.Phone.jsproj.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
