[
https://issues.apache.org/jira/browse/CB-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218438#comment-15218438
]
ASF subversion and git services commented on CB-10977:
------------------------------------------------------
Commit 6aeb9d9d1a91c2657218e6c81dfe2b57bd46f7d7 in cordova-plugin-file's branch
refs/heads/master from Richard Knoll
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=6aeb9d9 ]
CB-10977 android: Removing global state used for permission requests
This closes #174
> Overlapping permission requests in Android can cause errors
> -----------------------------------------------------------
>
> Key: CB-10977
> URL: https://issues.apache.org/jira/browse/CB-10977
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Environment: Marshmallow
> Reporter: Richard B Knoll
> Assignee: Richard B Knoll
> Priority: Critical
> Labels: android, mustfix, reproduced, triaged
>
> We use global state for permission requests in the file plugin that gets
> overwritten on each call to the plugin. That means that if multiple
> writes/reads are performed while the permission request is pending, the
> global state will get overwritten and callbacks will not be returned
> correctly. For example,
> {code}
> getFile('test1', {create:true}, function(){}, function(){});
> getDirectory('test2', {create:true}, function(){}, function(){});
> {code}
> In the above code block, only the second call ({{getDirectory}}) would get a
> success or error callback. Furthermore, this code will attempt to create both
> a directory and a file named {{test1}} because the permission callback for
> the first call will be executed using the arguments from the second call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
