[
https://issues.apache.org/jira/browse/CB-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228296#comment-15228296
]
ASF GitHub Bot commented on CB-10964:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/286
CB-10964 build.js script under "platforms\android\cordova\lib" can no…
…t handle build.json file starting with a BOM
[Jira issue](https://issues.apache.org/jira/browse/CB-10964)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-10964
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit e08ba99f40799882bd0d03be62bdf2ceaba2e356
Author: daserge <[email protected]>
Date: 2016-04-06T13:36:43Z
CB-10964 build.js script under "platforms\android\cordova\lib" can not
handle build.json file starting with a BOM
----
> build.js script under "platforms\android\cordova\lib" can not handle
> build.json file starting with a BOM
> --------------------------------------------------------------------------------------------------------
>
> Key: CB-10964
> URL: https://issues.apache.org/jira/browse/CB-10964
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Windows
> Affects Versions: 3.5.0
> Environment: All development platforms
> Reporter: Shuqian Ying
> Assignee: Sergey Shakhnazarov
> Priority: Minor
>
> The generated build.js file under the "platforms\android\cordova\lib"
> directory of a project throws exceptions when reading the utf-8 encoded
> build.json file under the root directory of the same project that starts with
> a byte order mark (BOM), due to a bug/feature of the Javascript JSON.parse
> method. Such kind of files are normally generated in automated build systems,
> like ours.
> The solution we found is to strip that mark before parsing, namely, inside of
> the function "parseOpts", use the following line
> ....
> var config = JSON.parse(buildjson.replace(/^\uFEFF/, ''));
> ...
> instead of
> ....
> var config = JSON.parse(buildjson);
> ...
> This has always been a problem up to the most recent stable version (3.5.0)
> and most likely to cause the same problem for other platforms, besides
> android.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
