[
https://issues.apache.org/jira/browse/CB-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230789#comment-15230789
]
ASF GitHub Bot commented on CB-10960:
-------------------------------------
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58922573
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader();
fileReader.onload = function() {
// Call this method again, with the arraybuffer as argument
- FileWriter.prototype.write.call(that, this.result);
+ FileWriter.prototype.write.call(that, this.result, true /*
isPendingBlobReadResult */);
};
+ fileReader.onerror = function (evt) {
+ // DONE state
+ that.readyState = FileWriter.DONE;
+
+ // Save error
+ that.error = evt.target.error;
--- End diff --
I think **evt.target** here is the same as **this** in the callback, and
they both refer to the FileReader instance, right? It's a bit confusing that
you use **evt.target** here, but **this** is used in the **onload** callback.
(I can't actually find documentation that says **this** in a FileReader
callback is set to the FileReader, though it seems like a reasonable
assumption.)
> Uncaught #<FileError> in write() when readyState != WRITING ?
> -------------------------------------------------------------
>
> Key: CB-10960
> URL: https://issues.apache.org/jira/browse/CB-10960
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 4.1.1
> Environment: Android
> Reporter: Samo Dadela
> Labels: android
> Attachments: code.js
>
>
> Excuse me if I did something stupid - I'm new to Cordova and JS.
> I thought that calling write() after checking readyState != WRITING would
> work.
> {code}
> function writeQueue(c) {
> while ( !(logWriter.readyState === FileWriter.WRITING) ) {
> var msg = logQueue.dequeue();
> if (!msg) {
> return;
> }
> var blob = new Blob([msg+c], { type: 'text/plain' });
> logWriter.write(blob);
> }
> }
> }
> {code}
> But I get:
> 0 277161 log log writer: cdvfile://localhost/files/bala.log
> 1 277199 log log writer: onwriteend
> 2 283616 log log writer: onwriteend
> 3 283629 log log writer: onwriteend
> 4 283651 error Uncaught #<FileError>,
> http://192.168.1.200:8100/plugins/cordova-plugin-file/www/FileWriter.js,
> Line: 130
> Line 130 is:
> {code}
> // Throw an exception if we are already writing a file
> if (this.readyState === FileWriter.WRITING) {
> throw new FileError(FileError.INVALID_STATE_ERR);
> }
> {code}
> How can readyState change to WRITING ?
> Note: Queue is pure Javascript
> (http://code.stephenmorley.org/javascript/queues/Queue.src.js)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
