[ 
https://issues.apache.org/jira/browse/CB-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232439#comment-15232439
 ] 

ASF GitHub Bot commented on CB-11024:
-------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/165#discussion_r59051696
  
    --- Diff: template/cordova/lib/ConfigParser.js ---
    @@ -73,6 +73,15 @@ WindowsConfigParser.prototype.getWindowsTargetVersion = 
function() {
         return preference;
     };
     
    +WindowsConfigParser.prototype.getUAPTargetMinVersion = function() {
    +    var preference = this.getPreference('uap-target-min-version');
    +
    +    if (!preference)
    --- End diff --
    
    Nit: code style: It just best to always add curlies for blocks - 
indentation based on editor tabs and other things can sometimes cause errors.


> Add preference to change min supported version in csproj file in Windows
> ------------------------------------------------------------------------
>
>                 Key: CB-11024
>                 URL: https://issues.apache.org/jira/browse/CB-11024
>             Project: Apache Cordova
>          Issue Type: Task
>            Reporter: Raghav Katyal
>            Assignee: Raghav Katyal
>              Labels: cordova-windows
>
> The current values in csproj are based on the SDKs installed on the machine 
> and are not customizable by user. This preference will allow to change the 
> min supported version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to