[
https://issues.apache.org/jira/browse/CB-11022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236155#comment-15236155
]
ASF GitHub Bot commented on CB-11022:
-------------------------------------
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-208603032
OK, I didn't realize config file transformations were also done already in
plugin add. And I think I have a better understanding of the code now.
My understanding is we still need to do prepare for any platforms which
don't do the following things:
1. Implement the PlatformApi
2. Copy over the plugins' www files in addPlugin()
3. Return true from addPlugin()
So do we also need changes to iOS and Windows platforms to do 2 and 3, to
match what you did for Android in the linked PR?
> Adding plugins prepares platforms, which is redundant and slow
> --------------------------------------------------------------
>
> Key: CB-11022
> URL: https://issues.apache.org/jira/browse/CB-11022
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Jason Ginchereau
> Assignee: Vladimir Kotikov
> Labels: triaged
>
> For CB-9617, a change was made to automatically do a 'cordova prepare'
> operation after adding every plugin. As part of the prepare, all the files
> from the project's www directory are re-copied into the platform_www
> directory. For a large project with lots of source files, images, and other
> resources, this copy operation is potentially time-consuming. And it is
> redundant and unnecessary when adding a plugin, because those files do not
> need to be changed when adding a plugin.
> For a large project with many plugins, this slow redundant operation is
> repeated for every plugin, making the first-time build (installing all the
> plugins) take a very long time. As an extreme case, a customer reported their
> large project (35 plugins, ~150 MB in www) takes about 2 hours to build the
> first time. Most of that time is spent repeatedly preparing the platforms
> after adding each plugin. The log line that appears to be slow says it is
> "Generating config.xml from defaults for platform <platform>", but what it is
> actually doing is redundantly copying lots of files from www.
> This issue can also be observed at a smaller scale when building the Cordova
> mobilespec project, which contains tests for all the core plugins.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
