[
https://issues.apache.org/jira/browse/CB-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237092#comment-15237092
]
ASF GitHub Bot commented on CB-6992:
------------------------------------
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-ios/pull/216
CB-6992 Fix non-working create case, add new test
Added name normalization from prepare to createProject in order to support
the case where the user edits name in config.xml, then adds ios platform to
project.
Also added a new test since the existing test was passing. The new test
used a different unicode string. It fails without this fix and passes with this
fix.
Please see [this JIRA
comment](https://issues.apache.org/jira/browse/CB-6992?focusedCommentId=15237088&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15237088)
for additional background info.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony--/cordova-ios CB6992-platform-api-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #216
----
commit c2a4ebbf81f3b088bb00ebaf499e0068337ff6ab
Author: Tony Homer <[email protected]>
Date: 2016-04-11T20:27:59Z
CB-6992 Fix non-working create case, add new test
----
> iOS platform add/prepare fails if app display name contains unicode
> characters.
> -------------------------------------------------------------------------------
>
> Key: CB-6992
> URL: https://issues.apache.org/jira/browse/CB-6992
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Affects Versions: 3.5.0
> Environment: uname: Darwin 13.1.0 Darwin Kernel Version 13.1.0: Thu
> Jan 16 19:40:37 PST 2014; root:xnu-2422.90.20~2/RELEASE_X86_64 x86_64
> cordova-dev -v: 3.5.0-0.2.4
> cordova-lib: 0.21.3
> Node 0.10.26
> iOS
> Reporter: Vladimir Kotikov
> Assignee: Shazron Abdullah
> Priority: Critical
> Labels: cli, configParser, cordova-ios-4.0.x, ios, ios-deploy
>
> Repro steps:
> # cordova create test-umlaÜt com.test.umlaÜt umlaÜt
> # cd test-umlaÜt/
> # cordova platform add ios
> Platform add fails with following error:
> {noformat}
> mv: dest file already exists:
> /Users/user/test/test-umlaÜt/platforms/ios/umlaÜt/umlaÜt-Info.plist
> mv: dest file already exists:
> /Users/user/test/test-umlaÜt/platforms/ios/umlaÜt/umlaÜt-Prefix.pch
> shell.js: internal error
> Error: EINVAL, invalid argument
> '/Users/user/test/test-umlaÜt/platforms/ios/umlaÜt.xcodeproj'
> at Object.fs.renameSync (fs.js:543:18)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/shelljs/shell.js:495:8
> at Array.forEach (native)
> at Object._mv
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/shelljs/shell.js:471:11)
> at Object.mv
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/shelljs/shell.js:1491:23)
> at pbxProject.<anonymous>
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/metadata/ios_parser.js:145:27)
> at pbxProject.EventEmitter.emit (events.js:98:17)
> at pbxProject.<anonymous>
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/xcode/lib/pbxProject.js:30:18)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at handleMessage (child_process.js:318:10)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
