[
https://issues.apache.org/jira/browse/CB-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245796#comment-15245796
]
ASF GitHub Bot commented on CB-11066:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/168
CB-11066 Remove uap prefixed capabilities when plugin has added regular ones
This fixes a problem when some of capabilities, added by plugin are being
modified at 'prepare' stage due to special Windows logic and then aren't
removed when uninstalling plugin. For details see
[CB-11066](https://issues.apache.org/jira/browse/CB-11066)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-11066
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 3300b14cb59d16d0dd60aadae2608401c6f635a0
Author: Vladimir Kotikov <[email protected]>
Date: 2016-04-18T09:00:51Z
CB-11066 Remove uap prefixed capabilities along with regular ones
----
> uap-prefixed capabilities are not being removed from
> package.windows10.appxmanifest on plugin rm
> ------------------------------------------------------------------------------------------------
>
> Key: CB-11066
> URL: https://issues.apache.org/jira/browse/CB-11066
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Vladimir Kotikov
> Labels: triaged
>
> 1. Some cordova-plugin-capabities {{plugin.xml}} includes:
> {noformat}
> <config-file target="package.appxmanifest" parent="/Package/Capabilities"
> device-target="windows">
> <Capability Name="enterpriseAuthentication" />
> <Capability Name="privateNetworkClientServer" />
> <Capability Name="sharedUserCertificates" />
> </config-file>
> {noformat}
> 2. cordova plugin add ..\cordova-plugin-capabities
> 3. package.windows10.appxmanifest now includes:
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> <uap:Capability Name="enterpriseAuthentication" />
> <Capability Name="privateNetworkClientServer" />
> <uap:Capability Name="sharedUserCertificates" />
> </Capabilities>
> {noformat}
> 4. cordova plugin rm cordova-plugin-capabities
> 5. package.windows10.appxmanifest now actually includes:
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> <uap:Capability Name="enterpriseAuthentication" />
> <uap:Capability Name="sharedUserCertificates" />
> </Capabilities>
> {noformat}
> *Expected*:
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> </Capabilities>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
