[ 
https://issues.apache.org/jira/browse/CB-11084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247542#comment-15247542
 ] 

ASF GitHub Bot commented on CB-11084:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/92#discussion_r60209862
  
    --- Diff: medic/medic-appium.js ---
    @@ -222,6 +223,37 @@ function getLocalCLI(appPath) {
         return "./cordova";
     }
     
    +function getConfigPath(appPath) {
    +    return path.join(appPath, "config.xml");
    +}
    +
    +function parseElementtreeSync(filename) {
    +    var contents = fs.readFileSync(filename, util.DEFAULT_ENCODING);
    +    if(contents) {
    --- End diff --
    
    If the file is empty the rest of the code is not valid anymore. Maybe throw 
an exception here if there is `!contents`?


> Implement an Appium test for CB-10873
> -------------------------------------
>
>                 Key: CB-11084
>                 URL: https://issues.apache.org/jira/browse/CB-11084
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Appium, Medic, Plugin Camera
>         Environment: iOS
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>
> Make Appium test the following scenario:
> When this preference is present in config.xml:
> <preference name="CameraUsesGeolocation" value="true" />
> The app shouldn't crash on iOS when taking a JPEG picture.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to