[ 
https://issues.apache.org/jira/browse/CB-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247771#comment-15247771
 ] 

ASF GitHub Bot commented on CB-10761:
-------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/428

    CB-10761 Resore plugins saved without spec attribute

    This PR updates plugin restore logic to restore plugins that were added to 
plugin.xml without `spec` attribute. See 
[CB-10761](https://issues.apache.org/jira/browse/CB-10761) for details

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-10761

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #428
    
----
commit eddc73e3f3ad538dd48c064ef467c2a3b12df8d5
Author: Vladimir Kotikov <[email protected]>
Date:   2016-04-19T11:37:46Z

    CB-10761 Resore plugins saved without spec attribute

----


> cordova prepare does not restore saved plugins with no version
> --------------------------------------------------------------
>
>                 Key: CB-10761
>                 URL: https://issues.apache.org/jira/browse/CB-10761
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Richard B Knoll
>              Labels: reproduced, triaged
>
> If you give a plugin element in config.xml but do not give the {{spec}} 
> attribute like so:
> {code}
> <plugin name="cordova-plugin-inappbrowser" />
> {code}
> Then when you run {{cordova prepare}} the CLI will not install the plugin but 
> will print out a message saying that it is installing it.
> {code}
> $ cordova prepare
>   Discovered plugin "cordova-plugin-inappbrowser" in config.xml. Installing 
> to the project
> {code}
> Giving the {{spec}} attribute causes the same message but the plugin will 
> actually be installed. I'm not sure what the intended behavior is, but we 
> need to fix it and add some test cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to