[
https://issues.apache.org/jira/browse/CB-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254432#comment-15254432
]
ASF GitHub Bot commented on CB-11127:
-------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/584#discussion_r60784438
--- Diff: www/.htaccess ---
@@ -61,14 +63,14 @@ RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/latest$
{{site.baseurl}}/docs/$1/latest/ [R
#
# docs/*/XX/* -> docs/*/YY/*
#
-{% for redirect in site.data.redirects.version-renames %}RewriteRule
^.*docs/(\w\w(?:-\w\w)?)/{{redirect.old}}/(.*)$
{{site.baseurl}}/docs/$1/{{redirect.new}}/$2 [R=302,L]
+{% for redirect in site.data.redirects.version-renames %}RewriteRule
^.*docs/(\w\w(?:-\w\w)?)/{{redirect[0]}}/(.*)$
{{site.baseurl}}/docs/$1/{{redirect[1]}}/$2 [R=302,L]
--- End diff --
The resulting `.htaccess` file has too many spaces if we add an extra space
like this:
{% for ... %}
RewriteRule ...
{% endfor %}
because it will render as:
RewriteRule ...
RewriteRule ...
We can still refactor it from this:
{% for ... %}RewriteRule ...
{% endfor %}
to this:
{% for ... %}
RewriteRule ... {% endfor %}
Which do you think is better?
> Version/language dropdowns and 'deprecated' warnings shouldn't lead to 404s
> ---------------------------------------------------------------------------
>
> Key: CB-11127
> URL: https://issues.apache.org/jira/browse/CB-11127
> Project: Apache Cordova
> Issue Type: Bug
> Components: Docs
> Reporter: Dmitry Blotsky
> Assignee: Dmitry Blotsky
> Original Estimate: 48h
> Remaining Estimate: 48h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
