[
https://issues.apache.org/jira/browse/CB-11153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257561#comment-15257561
]
ASF GitHub Bot commented on CB-11153:
-------------------------------------
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214615174
## [Current coverage][cc-pull] is **100%**
> Merging [#299][cc-pull] into [master][cc-base-branch] will increase
coverage by **+63.87%**
```diff
@@ master #299 diff @@
=======================================
Files 11 11
Lines 927 1690 +763
Methods 0 204 +204
Branches 167 167
=======================================
+ Hits 335 1690 +1355
+ Misses 592 0 -592
Partials 0 0
```
1. 10 files (not in diff) in `...emplates/cordova/lib` were modified.
[more](https://codecov.io/gh/apache/cordova-android/commit/e809144cf377f3d1c9bd9d0303c6ea7e5cdda4ba/changes?src=pr#62696E2F74656D706C617465732F636F72646F76612F6C6962)
- Misses `-503`
- Hits `+1121`
1. 1 files (not in diff) in `...in/templates/cordova` were modified.
[more](https://codecov.io/gh/apache/cordova-android/commit/e809144cf377f3d1c9bd9d0303c6ea7e5cdda4ba/changes?src=pr#62696E2F74656D706C617465732F636F72646F7661)
- Misses `-89`
- Hits `+234`
[][cc-pull]
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by e809144
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/299?src=pr
> Use Gradle 2.8 correctly for building Android projects
> ------------------------------------------------------
>
> Key: CB-11153
> URL: https://issues.apache.org/jira/browse/CB-11153
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Nikhil Khandelwal
>
> In build.gradle we have this:
> {code}
> task wrapper(type: Wrapper) {
> gradleVersion = '2.8'
> }
> {code}
> However, we do not have the gradle version specified correctly in prepEnv:
> {code}
> // If the gradle distribution URL is set, make sure it points to
> version we want.
> // If it's not set, do nothing, assuming that we're using a future
> version of gradle that we don't want to mess with.
> // For some reason, using ^ and $ don't work. This does the job,
> though.
> var distributionUrlRegex = /distributionUrl.*zip/;
> /*jshint -W069 */
> var distributionUrl =
> process.env['CORDOVA_ANDROID_GRADLE_DISTRIBUTION_URL'] ||
> 'http\\://services.gradle.org/distributions/gradle-2.2.1-all.zip';
> /*jshint +W069 */
> var gradleWrapperPropertiesPath = path.join(self.root, 'gradle',
> 'wrapper', 'gradle-wrapper.properties');
> shell.chmod('u+w', gradleWrapperPropertiesPath);
> shell.sed('-i', distributionUrlRegex,
> 'distributionUrl='+distributionUrl, gradleWrapperPropertiesPath);
> {code}
> One side effect of this is that it improves build performance significantly -
> on my machine by 1 second - on a "helloworld" project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
