[ 
https://issues.apache.org/jira/browse/CB-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262584#comment-15262584
 ] 

ASF GitHub Bot commented on CB-11166:
-------------------------------------

Github user riknoll commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61468850
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -114,14 +116,15 @@ describe('Contacts Android', function () {
                 })
                 .click()
                 .context(webviewContext)
    -            .executeAsync(function (pID, cb) {
    +            .executeAsync(function (pID, getOnlyBirthday, cb) {
    --- End diff --
    
    Okay, that's fine then. It might be better to just always return a contact 
object but convert the birthday to a string so that the function always returns 
the same type.


> Implement an Appium test checking if contact birthday is saved properly
> -----------------------------------------------------------------------
>
>                 Key: CB-11166
>                 URL: https://issues.apache.org/jira/browse/CB-11166
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Appium, Plugin Contacts
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to