[
https://issues.apache.org/jira/browse/CB-11218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274610#comment-15274610
]
ASF GitHub Bot commented on CB-11218:
-------------------------------------
GitHub user adzellman opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/76
CB-11218 Convert button list to appropriate type
- If the buttons are passed in as a comma-separated
string, then create an array with those values.
JIRA: https://issues.apache.org/jira/browse/CB-11218
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/adobe-marketing-cloud-mobile/cordova-plugin-dialogs
CB-11218cordova-plugin-dialogs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 28633f14e1f02db8440e6465246597cac7c809d0
Author: Andrew Zellman <[email protected]>
Date: 2016-05-06T19:17:24Z
CB-11218 Convert button list to appropriate type
- If the buttons are passed in as a comma-separated
string, then create an array with those values.
----
> Prompt method should not crash if a string is passed as button value
> --------------------------------------------------------------------
>
> Key: CB-11218
> URL: https://issues.apache.org/jira/browse/CB-11218
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
> Environment: iOS
> Reporter: Andrew Zellman
> Assignee: Andrew Zellman
> Labels: easyfix
>
> The prompt method expects an array as an argument in the command array, but
> there is no input validation requiring that it be an array. A string makes
> just as much sense for a single-button dialog, but if the API user sends a
> string, it crashes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
