[
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288933#comment-15288933
]
Michael Schmidt commented on CB-11241:
--------------------------------------
Ok, cordova prepare changed it's behaviour since January - adding the BOM
attribute now only takes place in the build step instead of the prepare step.
background:
* CB-10193 Add BOM to www files at build stage instead of prepare
http://mail-archives.apache.org/mod_mbox/cordova-commits/201601.mbox/%[email protected]%3E
* http://markmail.org/thread/cg5s2jvxvyyqcqpd
My workflow for debugging (and creating releases manually) is as follows:
* build js-app - with angular, ionic, with gulp & browserify
* 'cordova prepare'
* release ios & android platforms in automated process
* manually release windows platform
** open windows VM
** open visual studio
** deploy app
** create app package from within visual studio
-> this process worked for ages & now broke after upgrading the cordova version
to 6.1.1
-> the BOM gets added using the 'cordova build' command
overall this change seems to be confusing:
- 'cordova prepare' used to "prepare" the sources for packaging - across all
platforms. 'cordova build' used to package the sources for each platform
- now 'cordova prepare' doesn't completely prepare the sources as only the
windows needs an additional step - which is 'hidden' in the build phase
> File encoding test fails with UTF-8 file encoding error on windows store
> submission
> -----------------------------------------------------------------------------------
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
> Affects Versions: 6.1.1
> Reporter: Michael Schmidt
> Labels: cannot-reproduce, triaged, wfc
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
> form with a corresponding byte-order mark (BOM) in order to benefit from
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the
> File menu in Visual Studio. Select the drop-down control next to the Save
> button and select "Save with Encoding..." option. From the Advanced save
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click
> the OK button.
> ````
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
