[
https://issues.apache.org/jira/browse/CB-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293992#comment-15293992
]
ASF GitHub Bot commented on CB-11284:
-------------------------------------
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/253#discussion_r64092365
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
return cli(inputArgs);
}).then(function () {
if (shouldCollectTelemetry && !isTelemetryCmd) {
- telemetry.track(cmd, 'successful');
+ telemetry.track(cmd, subcommand, 'successful');
}
// call cb with error as arg if something failed
cb(null);
}).fail(function (err) {
if (shouldCollectTelemetry && !isTelemetryCmd) {
- telemetry.track(cmd, 'unsuccessful');
+ telemetry.track(cmd, subcommand, 'unsuccessful');
--- End diff --
Ah, I see you check for it below. I think the code might be cleaner/easier
to understand if you just do the check here rather than manually deleting null
values from the arguments array.
> Telemetry: Log platform/plugin subcommands
> ------------------------------------------
>
> Key: CB-11284
> URL: https://issues.apache.org/jira/browse/CB-11284
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
> Reporter: Omar Mefire
> Assignee: Omar Mefire
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
