[ 
https://issues.apache.org/jira/browse/CB-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310256#comment-15310256
 ] 

ASF GitHub Bot commented on CB-11352:
-------------------------------------

Github user codecov-io commented on the pull request:

    https://github.com/apache/cordova-ios/pull/225
  
    ## [Current coverage][cc-pull] is **51.81%**
    > Merging [#225][cc-pull] into [master][cc-base-branch] will not change 
coverage
    
    ```diff
    @@             master       #225   diff @@
    ==========================================
      Files            11         11          
      Lines           882        882          
      Methods         132        132          
      Messages          0          0          
      Branches        143        143          
    ==========================================
      Hits            457        457          
      Misses          425        425          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[3d3a746...158be71][cc-compare]
    [cc-base-branch]: 
https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
    [cc-compare]: 
https://codecov.io/gh/apache/cordova-ios/compare/3d3a746cf86f63908da513a7c12001ee6dac7ebb...158be717d8479cce6050228893c2f6c5aa8677b0
    [cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/225?src=pr


> WKWebView doesn't apply User-Agent configuration
> ------------------------------------------------
>
>                 Key: CB-11352
>                 URL: https://issues.apache.org/jira/browse/CB-11352
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 4.1.1
>            Reporter: Andreas Kohn
>            Assignee: Shazron Abdullah
>
> {{config.xml}} contains 
> {code}
> <preference name="AppendUserAgent" value="something/version"/>
> {code}
> This is properly used for Android (cordova-android 5.1.1), but not with 
> iOS+WKWebView (cordova-ios 4.1.1).
> The cause is actually "documented": CDVUserAgentUtil:setUserAgent says that 
> the default settings must be registered before the webview is actually 
> instantiated. But, CDVViewController:viewDidLoad delays the call to 
> setUserAgent until after the view has been created.
> AFAIR this worked with the UIWebView.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to