[
https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caryn Tran updated CB-11412:
----------------------------
Description:
https://github.com/cordova/cordova-discuss/pull/49
Sometimes we do want a `package.json` copied over. `package.json` could have
build scripts that are essential for the template to work. To handle this use
case, template authors are suggested to put template files in a subdirectory
and point to that subdirectory in index.js. All files in the subdirectory are
copied over.
Update the current template implementation to ignore the list of files above
that shouldn't be copied over when using `--template`. If a subdirectory is
used, copy the entire contents of the subdirectory.
If a `package.json` exists in the subdirectory, we should update its fields
like we do to `config.xml`.
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
Only field to update in `package.json` should be `package.name`.
`package.name` should be updated to use `config.name` lowercased (npm package
names have to be lowercase). `config.name` is the optional third argument
`cordova create` takes.
was:
https://github.com/cordova/cordova-discuss/pull/49
Sometimes we do want a `package.json` copied over. `package.json` could have
build scripts that are essential for the template to work.
Update the current template implementation to ignore the list of files above
that shouldn't be copied over when using `--template`. If a subdirectory is
used, copy the entire contents of the subdirectory.
If a `package.json` exists in the subdirectory, we should update its fields
like we do to `config.xml`.
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
Only field to update in `package.json` should be `package.name`.
`package.name` should be updated to use `config.name` lowercased (npm package
names have to be lowercase). `config.name` is the optional third argument
`cordova create` takes.
> Update template implementation in cordova create --template
> -----------------------------------------------------------
>
> Key: CB-11412
> URL: https://issues.apache.org/jira/browse/CB-11412
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Caryn Tran
> Assignee: Caryn Tran
>
> https://github.com/cordova/cordova-discuss/pull/49
> Sometimes we do want a `package.json` copied over. `package.json` could have
> build scripts that are essential for the template to work. To handle this use
> case, template authors are suggested to put template files in a subdirectory
> and point to that subdirectory in index.js. All files in the subdirectory are
> copied over.
> Update the current template implementation to ignore the list of files above
> that shouldn't be copied over when using `--template`. If a subdirectory is
> used, copy the entire contents of the subdirectory.
> If a `package.json` exists in the subdirectory, we should update its fields
> like we do to `config.xml`.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
> Only field to update in `package.json` should be `package.name`.
> `package.name` should be updated to use `config.name` lowercased (npm package
> names have to be lowercase). `config.name` is the optional third argument
> `cordova create` takes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
