[
https://issues.apache.org/jira/browse/CB-11375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332077#comment-15332077
]
ASF GitHub Bot commented on CB-11375:
-------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/229
I agree about the CI failure.
Check out this commit:
https://github.com/apache/cordova-ios/commit/2e41e221d50dd00b832879cd3b4ced372f8be428
I think it fixes this problem -- although the description seems unrelated,
if you go to the JIRA issue there are more details:
https://issues.apache.org/jira/browse/CB-11375
> onReset method of CDVPlugin is never called
> -------------------------------------------
>
> Key: CB-11375
> URL: https://issues.apache.org/jira/browse/CB-11375
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 6.1.1, 6.2.0
> Reporter: Dale Beermann
> Assignee: Shazron Abdullah
> Labels: triaged
>
> {{CDVUIWebViewNavigationDelegate.webViewDidStartLoad}} gets called as it
> should. The line in that method:
> {code}
> [[NSNotificationCenter defaultCenter] postNotification:[NSNotification
> notificationWithName:CDVPluginResetNotification
> object:self.enginePlugin.webView]];
> {code}
> seems to be an issue. The {{self.enginePlugin.webView}} reference calls into
> the {{webView}} method in {{CDVPlugin.m}}. There, the lines:
> {code}
> if (self.webViewEngine != nil) {
> return self.webViewEngine.engineWebView;
> }
> {code}
> should return the {{engineWebView}}, but instead it returns nil. I think that
> the issue is that {{CDVUIWebViewEngine}} extends {{CDVPlugin}}, but doesn't
> override the {{webView}} method. If I do override that getter in
> {{CDVUIWebViewEngine.m}}, with:
> {code}
> - (UIView*)webView
> {
> if (self.engineWebView != nil) {
> return self.engineWebView;
> }
>
> return nil;
> }
> {code}
> everything actually seems to get called correctly. I'm running Cordova 6.1.1
> with Cordova iOS 4.1.1. It does not look like there are any changes since
> then that would affect this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
