[
https://issues.apache.org/jira/browse/CB-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336282#comment-15336282
]
ASF GitHub Bot commented on CB-11430:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/102
CB-11430 Report duration's NaN value to JS properly
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fixes incorrect duration value reported to JavaScript when media stream
duration is infinite
### What testing has been done on this change?
Manual testing + plugin automated tests
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-plugin-media CB-11430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit d30da8c10655b869528466b0ebd0a2cbff0f4c03
Author: Vladimir Kotikov <[email protected]>
Date: 2016-06-17T13:53:29Z
CB-11430 Report duration NaN value to JS properly
----
> iOS Media plugin tests are failing
> ----------------------------------
>
> Key: CB-11430
> URL: https://issues.apache.org/jira/browse/CB-11430
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
> Affects Versions: Master, 2.3.1-dev
> Environment: Saucelabs emulator
> Reporter: Vladimir Kotikov
> Labels: found-by-ci, ios, media, triaged
>
> There are the following tests failures:
> {noformat}
> ✗ media.spec.19 position should be set properly
> - Error: Timeout - Async callback was not invoked within timeout specified
> by jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> file:///Users/chef/Library/Developer/CoreSimulator/Devices/78AD85A2-C472-498D-A53E-84D74E5F1BAB/data/Containers/Bundle/Application/EB5CE92A-9BC1-4048-B53D-5BD20757B12C/HelloCordova.app/www/cdvtests/jasmine-2.2.0/jasmine.js
> (line 1764)
> ✗ media.spec.20 duration should be set properly
> - Error: Timeout - Async callback was not invoked within timeout specified
> by jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> file:///Users/chef/Library/Developer/CoreSimulator/Devices/78AD85A2-C472-498D-A53E-84D74E5F1BAB/data/Containers/Bundle/Application/EB5CE92A-9BC1-4048-B53D-5BD20757B12C/HelloCordova.app/www/cdvtests/jasmine-2.2.0/jasmine.js
> (line 1764)
> ✗ media.spec.21 should be able to resume playback after pause
> - media1 = new Media - Error creating Media object. Media file:
> https://cordova.apache.org/downloads/BlueZedEx.mp3
> ✗ media.spec.22 should be able to seek through file
> - media1 = new Media - Error creating Media object. Media file:
> https://cordova.apache.org/downloads/BlueZedEx.mp3
> ✗ media.spec.24 playback rate should be set properly using setRate
> - Expected 0 to be close to 5, 0.
> - Expected false to be truthy.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
