[
https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356677#comment-15356677
]
ASF GitHub Bot commented on CB-11516:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/179
## [Current coverage][cc-pull] is **72.17%**
> Merging [#179][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@ master #179 diff @@
==========================================
Files 14 14
Lines 1905 1905
Methods 351 351
Messages 0 0
Branches 385 385
==========================================
Hits 1375 1375
Misses 530 530
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by
[04a0099...0f1be17][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/cordova-windows/compare/04a0099ddc10ce4e92baa7718ecd7ac8b0ee457d...0f1be175ca6f6b37fa6f52b4d3ba9c7650a13281
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/179?src=pr
> Preparing fails on icons with a target
> --------------------------------------
>
> Key: CB-11516
> URL: https://issues.apache.org/jira/browse/CB-11516
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.4.0
> Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source
> directory does not exist: Square44x44Logo_100.scale"
> <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory
> information was lost. `copyMrtImage` in an earlier commit preserved this
> information (shown in the link below), but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually
> only returns an array of the filenames. This caused the `copyIcons` spec to
> pass but the code failed when used.
> I have a fix ready for github.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
