[
https://issues.apache.org/jira/browse/CB-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361094#comment-15361094
]
ASF GitHub Bot commented on CB-11532:
-------------------------------------
GitHub user philbenoit opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/130
CB-11532: (ios) Fix bug with bad characters in contact name
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fixes https://issues.apache.org/jira/browse/CB-11532
### What testing has been done on this change?
Testing on the problem device iOS 9.3 - iPhone 5s.
### Checklist
- [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed
and submitted to [email protected].
- [ Yes ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug
with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the
platform affected.
- [ No ] Added automated test coverage as appropriate for this change.
This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit
heavy to create new dictionaries for each user.
Please also look to add code tests as I have no knowledge of this, the
names causing issues are listed below.
I have tested this in the wild with a phone containing the contacts below
and it has solved the issue.
Gökmen
Brûlé
França
ادوارد
Gabby ••••
Damián M.A.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/philbenoit/cordova-plugin-contacts patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 430770c51fc4377db1f8ef3f4e251c6189fcd29f
Author: KiwiDC <[email protected]>
Date: 2016-07-04T09:33:49Z
Update CDVContacts.m
This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit
heavy to create new dictionaries for each user.
I have tested this in the wild with a phone containing the contacts below
and it has solved the issue.
Gökmen
Brûlé
França
ادوارد
Gabby ••••
Damián M.A.
----
> Contacts EOF error on iOS
> -------------------------
>
> Key: CB-11532
> URL: https://issues.apache.org/jira/browse/CB-11532
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Affects Versions: 2.1.1
> Environment: Cordova CLI: 6.2.0
> Gulp version: CLI version 3.9.0
> Gulp local: Local version 3.9.1
> Ionic Framework Version: 2.0.0-beta.7
> Ionic CLI Version: 2.0.0-beta.32
> Ionic App Lib Version: 2.0.0-beta.18
> ios-deploy version: 1.8.5
> ios-sim version: 4.1.1
> OS: Mac OS X El Capitan
> Node Version: v4.1.1
> Xcode version: Xcode 7.3 Build version 7D175
> Reporter: Phil Benoit
> Labels: contacts, ios
>
> When importing contacts from Google or Facebook the plugin crashes as it is
> not able to handle the imported characters.
> The error is - Syntax error: EOF reached
> Here is a list of real world contacts imported from Google that cause the
> issue.
> Gökmen
> Brûlé
> França
> ادوارد
> Gabby ••••
> Damián M.A.
> I have a fix for this that has been implemented in a live app. I will be
> sending a pull request to the repo for review but wanted to log this incase
> there were others coming across the same issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
