[ https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361962#comment-15361962 ]
ASF GitHub Bot commented on CB-9825: ------------------------------------ Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504824 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers = { } }, uninstall:function(obj, plugin, project, options) { + var podsJSON = require(path.join(project.projectDir, 'pods.json')); var src = obj.src; if (!obj.custom) { var keepFrameworks = keep_these_frameworks; - if (keepFrameworks.indexOf(src) < 0) { - project.frameworks[src] -= (project.frameworks[src] || 1) - 1; - if (project.frameworks[src] < 1) { - // Only remove non-custom framework from xcode project - // if there is no references remains - project.xcode.removeFramework(src); - delete project.frameworks[src]; + if (obj.type === 'podspec') { + if(podsJSON[src]) { + if((podsJSON[src].count - 1) > 0) { + podsJSON[src].count = podsJSON[src].count - 1; + } else { + delete podsJSON[src]; + } + } + } else { + project.frameworks[src] -= (project.frameworks[src] || 1) - 1; --- End diff -- Not your code but I'm not sure if this code is correct. It's definitely confusing as heck. equivalent to ``` project.frameworks[src] = project.frameworks[src] - (project.frameworks[src] || 1) - 1 ``` > Support third-party package managers like Cocoapods and Nuget > ------------------------------------------------------------- > > Key: CB-9825 > URL: https://issues.apache.org/jira/browse/CB-9825 > Project: Apache Cordova > Issue Type: New Feature > Components: CordovaLib > Reporter: Shazron Abdullah > Assignee: Julia Geist > Labels: cordova-ios-5.0.x > > ML discussion: > http://markmail.org/message/5qvg6rwr4nz4q7mc > cordova-discuss proposal (to be brought back to the list when finalized): > https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md > From Steve Gill in the ML: > At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods > support to plugins as dependencies for iOS. > Cordova-android currently uses Gradle as a way to enable external > dependency resolution for plugins using the framework tag. > A suggestion about using the engine tag to fetch cocoapods-cli (mac) & > NuGet (windows) followed by using the framework tag was discussed. > The minutes[1] show Carlos, Shaz and Raghav as looking into the design. > Someone should write up a proposal on cordova-discuss[2] and create the > issues. Post them in this thread. > This shouldn't take priority over cordova-ios 4 issues. > [1] > https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing > [2] https://github.com/cordova/cordova-discuss -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org