[ 
https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373885#comment-15373885
 ] 

ASF GitHub Bot commented on CB-11412:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-app-hello-world/pull/16


> Update template implementation in cordova create --template
> -----------------------------------------------------------
>
>                 Key: CB-11412
>                 URL: https://issues.apache.org/jira/browse/CB-11412
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Caryn Tran
>            Assignee: Caryn Tran
>
> https://github.com/cordova/cordova-discuss/pull/49
> Sometimes we do want a `package.json` copied over. `package.json` could have 
> build scripts that are essential for the template to work. To handle this use 
> case, template authors are suggested to put template files in a subdirectory 
> and point to that subdirectory in index.js. All files in the subdirectory are 
> copied over.
> Update the current template implementation to ignore the list of files above 
> that shouldn't be copied over when using `--template`. If a subdirectory is 
> used, copy the entire contents of the subdirectory.
> If a `package.json` exists in the subdirectory, we should update its fields 
> like we do to `config.xml`. 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
>  Only field to update in `package.json` should be `package.name`. 
> `package.name` should be updated to use `config.name` lowercased (npm package 
> names have to be lowercase). `config.name` is the optional third argument 
> `cordova create` takes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to