[
https://issues.apache.org/jira/browse/CB-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374425#comment-15374425
]
ASF GitHub Bot commented on CB-11078:
-------------------------------------
GitHub user akilawickey opened a pull request:
https://github.com/apache/cordova-android/pull/316
CB-11078 Empty string for BackgroundColor preference crashes application
Fixed the bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akilawickey/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/316.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #316
----
commit f4a1956f0e66e61032a9179b4894a652e9717e96
Author: akilawickey <[email protected]>
Date: 2016-07-12T22:16:57Z
fixed CB-11078 Empty string for BackgroundColor preference crashes
application
----
> Empty string for BackgroundColor preference crashes application
> ---------------------------------------------------------------
>
> Key: CB-11078
> URL: https://issues.apache.org/jira/browse/CB-11078
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Environment: HTC One
> Android 6.0
> Cordova-Android 5.1.0
> Reporter: Ryan Willoughby
> Assignee: Joe Bowser
> Priority: Minor
> Labels: easyfix, triaged
>
> A preference of
> {{<preference name="BackgroundColor" value="" />}}
> will cause an a cordova application to crash on startup with a
> NumberFormatException:
> {color:red}
> 04-13 11:18:29.894: E/AndroidRuntime(20224): java.lang.RuntimeException:
> Unable to start activity
> ComponentInfo{com.whatever.whatever/com.whatever.whatever.ClassName}:
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2484)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2544)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread.access$900(ActivityThread.java:150)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread$H.handleMessage(ActivityThread.java:1394)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.os.Handler.dispatchMessage(Handler.java:102)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.os.Looper.loop(Looper.java:168)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread.main(ActivityThread.java:5845)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> java.lang.reflect.Method.invoke(Native Method)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:797)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:687)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): Caused by:
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> java.lang.Long.invalidLong(Long.java:124)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> java.lang.Long.decode(Long.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> org.apache.cordova.CordovaPreferences.getInteger(CordovaPreferences.java:78)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> org.apache.cordova.CordovaActivity.createViews(CordovaActivity.java:178)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> org.apache.cordova.CordovaActivity.init(CordovaActivity.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> org.apache.cordova.CordovaActivity.loadUrl(CordovaActivity.java:214)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> uk.directpath.staffssmartalert2.StaffsSmartAlertv2.onCreate(StaffsSmartAlertv2.java:32)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.Activity.performCreate(Activity.java:6248)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1125)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): at
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2437)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): ... 9 more
> {color}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
